ExtJS.Bugs: Difference between revisions
No edit summary |
No edit summary |
||
Line 59: | Line 59: | ||
return task; | return task; | ||
}; | }; | ||
== ext-2.1\source\data\Store.js:28-30 == | |||
The getKey function can be passed in the constructor. The getKey function override implementation is identical to the default getKey implementation. Suggest: delete lines 28-30. |
Revision as of 12:04, 24 June 2008
ext-2.0.2\source\util\MixedCollection.js:83-84
var old = this.map[key]; if ( old ) {
Will fail if false boolean values (or other falsey values) are stored in the collection.
Suggested fix:
var old = this.map[key]; if ( typeof old !== "undefined" ) {
ext-2.0.2\source\util\MixedCollection.js:391
c[c.length] = {key: k[i], value: items[i], index: i};
Two scripted operations instead of one. Why?
Suggested fix:
c.push( {key: k[i], value: items[i], index: i} );
ext-2.0.2\source\util\MixedCollection.js
Why aren't the "private" functions '_sort' and 'createValueMatcher' stored in a closure? Rather they are exposed as part of the public interface.
ext-2.1\source\util\TaskMgr.js:10-23
Example code, lines 10 to 23, seems like a bad idea. Using a static fly-weight object from a background "thread". This only works because the scripting environment isn't actually multi-threaded.
var task = { run: function(){ Ext.fly('clock').update(new Date().format('g:i:s A')); }, interval: 1000 //1 second }
ext-2.1\source\util\TaskMgr.js:108
Putting the task on the runnable queue before initialising it makes me nervous.
this.start = function(task){ tasks.push(task); task.taskStartTime = new Date().getTime(); task.taskRunTime = 0; task.taskRunCount = 0; startThread(); return task; };
Suggest:
this.start = function(task){ task.taskStartTime = new Date().getTime(); task.taskRunTime = 0; task.taskRunCount = 0; tasks.push(task); startThread(); return task; };
ext-2.1\source\data\Store.js:28-30
The getKey function can be passed in the constructor. The getKey function override implementation is identical to the default getKey implementation. Suggest: delete lines 28-30.