ExtJS.Bugs: Difference between revisions

From John's wiki
Jump to navigation Jump to search
No edit summary
No edit summary
Line 20: Line 20:


  c.push( {key: k[i], value: items[i], index: i} );
  c.push( {key: k[i], value: items[i], index: i} );
== ext-2.0.2\source\util\MixedCollection.js ==
Why aren't the "private" functions '_sort' and 'createValueMatcher' stored in a closure? Rather they are exposed as part of the public interface.

Revision as of 17:07, 29 May 2008

ext-2.0.2\source\util\MixedCollection.js:83-84

var old = this.map[key];
if ( old ) {

Will fail if false boolean values (or other falsey values) are stored in the collection.

Suggested fix:

var old = this.map[key];
if ( typeof old !== "undefined" ) {

ext-2.0.2\source\util\MixedCollection.js:391

c[c.length] = {key: k[i], value: items[i], index: i};

Two scripted operations instead of one. Why?

Suggested fix:

c.push( {key: k[i], value: items[i], index: i} );

ext-2.0.2\source\util\MixedCollection.js

Why aren't the "private" functions '_sort' and 'createValueMatcher' stored in a closure? Rather they are exposed as part of the public interface.